deemanone/padelnomics
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix directory search: SQL param order and HTMX include selector

Browse Source 
Parameter bindings for ORDER BY (now, country) were placed before WHERE
params, causing mismatched bindings when any filter was active. Also
switched hx-include from .dir-search class (shared by form + inputs)
to #dir-search-form ID to prevent duplicate parameters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Deeman
2026-02-17 14:16:21 +01:00
parent fc410920d8
commit cefdb7ce3a
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
padelnomics/src/padelnomics/directory/routes.py
View File

@@ -89,7 +89,7 @@ async def _build_directory_query(q, country, category, region, page, per_page=24
offset = (page - 1) * per_page offset = (page - 1) * per_page
# Tier-based ordering: sticky first, then pro > growth > free, then name # Tier-based ordering: sticky first, then pro > growth > free, then name
order_params = [now, country or ""] + params + [per_page, offset] order_params = params + [now, country or "", per_page, offset]
suppliers = await fetch_all( suppliers = await fetch_all(
f"""SELECT * FROM suppliers s WHERE {where} f"""SELECT * FROM suppliers s WHERE {where}
ORDER BY ORDER BY

13
padelnomics/src/padelnomics/directory/templates/directory.html
View File

@@ -158,28 +158,27 @@
</div> </div>
<!-- Search + Filters --> <!-- Search + Filters -->
<form method="get" class="dir-search"> <form method="get" class="dir-search" id="dir-search-form">
<input type="search" name="q" value="{{ q }}" placeholder="Search suppliers, countries, products..." <input type="search" name="q" value="{{ q }}" placeholder="Search suppliers, countries, products..."
class="dir-search"
hx-get="{{ url_for('directory.results') }}" hx-get="{{ url_for('directory.results') }}"
hx-trigger="input changed delay:300ms" hx-trigger="input changed delay:300ms"
hx-target="#dir-results" hx-target="#dir-results"
hx-include=".dir-search"> hx-include="#dir-search-form">
<select name="country" class="dir-search" <select name="country"
hx-get="{{ url_for('directory.results') }}" hx-get="{{ url_for('directory.results') }}"
hx-trigger="change" hx-trigger="change"
hx-target="#dir-results" hx-target="#dir-results"
hx-include=".dir-search"> hx-include="#dir-search-form">
<option value="">All Countries</option> <option value="">All Countries</option>
{% for cc in country_counts %} {% for cc in country_counts %}
<option value="{{ cc.country_code }}" {{ 'selected' if country == cc.country_code }}>{{ country_labels.get(cc.country_code, cc.country_code) }} ({{ cc.cnt }})</option> <option value="{{ cc.country_code }}" {{ 'selected' if country == cc.country_code }}>{{ country_labels.get(cc.country_code, cc.country_code) }} ({{ cc.cnt }})</option>
{% endfor %} {% endfor %}
</select> </select>
<select name="category" class="dir-search" <select name="category"
hx-get="{{ url_for('directory.results') }}" hx-get="{{ url_for('directory.results') }}"
hx-trigger="change" hx-trigger="change"
hx-target="#dir-results" hx-target="#dir-results"
hx-include=".dir-search"> hx-include="#dir-search-form">
<option value="">All Categories</option> <option value="">All Categories</option>
{% for cat in category_counts %} {% for cat in category_counts %}
<option value="{{ cat.category }}" {{ 'selected' if category == cat.category }}>{{ category_labels.get(cat.category, cat.category) }} ({{ cat.cnt }})</option> <option value="{{ cat.category }}" {{ 'selected' if category == cat.category }}>{{ category_labels.get(cat.category, cat.category) }} ({{ cat.cnt }})</option>