Compare commits

..

6 Commits

Author SHA1 Message Date
Deeman
28e44384ef merge: opportunity map HTMX data islands + remove dead API endpoint
All checks were successful
CI / test (push) Successful in 1m0s
CI / tag (push) Successful in 3s
# Conflicts:
#	transform/sqlmesh_padelnomics/models/serving/location_opportunity_profile.sql
#	web/src/padelnomics/api.py
#	web/src/padelnomics/public/templates/opportunity_map.html
2026-03-07 21:05:52 +01:00
Deeman
b1e008a2a4 refactor(maps): opportunity map → HTMX data islands, remove dead API endpoint
- Delete opportunity() JSON endpoint from api.py (dead after this refactor)
- Add GET /opportunity-map/data route returning HTML partial with two JSON
  data islands (opp_points + ref_points from serving.location_profiles)
- Create partials/opportunity_map_data.html (2-line data island partial)
- Rewrite opportunity_map.html: HTMX attrs on <select>, invisible #map-data
  swap target, htmx:afterSwap listener replaces fetch()-based loadCountry()

city_venues endpoint stays public (article-maps.js calls it on public pages).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-07 20:56:45 +01:00
Deeman
d556ceecee fix(api): restore public access to country_cities + opportunity endpoints
opportunity_map.html (public page) still fetches these. Only countries.json
and city_venues.json are no longer called from any public page, so those two
keep @login_required.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-07 20:41:12 +01:00
Deeman
f215ea8e3a fix: supply gap inflation + inline map data + guard API endpoints
A. location_profiles.sql: supply gap now uses GREATEST(catchment_padel_courts,
   COALESCE(city_padel_venue_count, 0)) so Playtomic venues prevent cities like
   Murcia/Cordoba/Gijon from receiving a full 30-pt supply gap bonus when their
   OSM catchment count is zero. Expected ~10-15 pt drop for affected ES cities.

B. pseo_country_overview.sql: add population-weighted lat/lon centroid columns
   so the markets map can use accurate country positions from this table.

C/D. content/routes.py + markets.html: query pseo_country_overview in the route
   and pass as map_countries to the template, replacing the fetch('/api/...') call
   with inline JSON. Map scores now match pseo_country_overview (pop-weighted),
   and the page loads without an extra round-trip.

E. api.py: add @login_required to all 4 endpoints. Unauthenticated callers get
   a 302 redirect to login instead of data.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-07 20:33:31 +01:00
Deeman
b2ffad055b fix(supervisor): use file path for export_serving (not -m module syntax)
All checks were successful
CI / test (push) Successful in 1m0s
CI / tag (push) Successful in 3s
-m padelnomics.export_serving resolves to web package, not src/padelnomics.
src/padelnomics is not a uv workspace member so it's not importable by name.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-07 18:08:46 +01:00
Deeman
c30a7943aa feat(transform): opportunity score v4 — market validation + population-weighted aggregation
Two targeted fixes for inflated country scores (ES 83, SE 77):

1. pseo_country_overview: replace AVG() with population-weighted averages
   for avg_opportunity_score and avg_market_score. Madrid/Barcelona now
   dominate Spain's average instead of hundreds of 30K-town white-space
   towns. Expected ES drop from ~83 to ~55-65.

2. location_opportunity_profile: replace dead sports culture component
   (10 pts, tennis data all zeros) with market validation signal.
   New country_market CTE aggregates city_market_profile per country_code.
   ES (~60/100) → ~6 pts (proven demand). SE (~35/100) → ~3.5 pts
   (struggling market). NULL → 0.5 neutral → 5 pts (untested market).

Score budget unchanged: 25+20+30+15+10 = 100 pts.
New dependency: location_opportunity_profile → serving.city_market_profile (no cycle).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-07 15:36:51 +01:00
9 changed files with 117 additions and 84 deletions

View File

@@ -42,7 +42,7 @@ do
# The web app detects the inode change on next query — no restart needed. # The web app detects the inode change on next query — no restart needed.
DUCKDB_PATH="${DUCKDB_PATH:-/data/padelnomics/lakehouse.duckdb}" \ DUCKDB_PATH="${DUCKDB_PATH:-/data/padelnomics/lakehouse.duckdb}" \
SERVING_DUCKDB_PATH="${SERVING_DUCKDB_PATH:-/data/padelnomics/analytics.duckdb}" \ SERVING_DUCKDB_PATH="${SERVING_DUCKDB_PATH:-/data/padelnomics/analytics.duckdb}" \
uv run python -m padelnomics.export_serving uv run python src/padelnomics/export_serving.py
) || { ) || {
if [ -n "${ALERT_WEBHOOK_URL:-}" ]; then if [ -n "${ALERT_WEBHOOK_URL:-}" ]; then

View File

@@ -208,7 +208,7 @@ scored AS (
-- Supply gap (30 pts): inverted catchment venue density -- Supply gap (30 pts): inverted catchment venue density
+ 30.0 * GREATEST(0.0, 1.0 - COALESCE( + 30.0 * GREATEST(0.0, 1.0 - COALESCE(
CASE WHEN catchment_population > 0 CASE WHEN catchment_population > 0
THEN catchment_padel_courts::DOUBLE / catchment_population * 100000 THEN GREATEST(catchment_padel_courts, COALESCE(city_padel_venue_count, 0))::DOUBLE / catchment_population * 100000
ELSE 0.0 ELSE 0.0
END, 0.0) / 8.0) END, 0.0) / 8.0)
-- Catchment gap (15 pts): distance to nearest court -- Catchment gap (15 pts): distance to nearest court

View File

@@ -37,6 +37,8 @@ SELECT
-- Use the most common currency in the country (MIN is deterministic for single-currency countries) -- Use the most common currency in the country (MIN is deterministic for single-currency countries)
MIN(price_currency) AS price_currency, MIN(price_currency) AS price_currency,
SUM(population) AS total_population, SUM(population) AS total_population,
ROUND(SUM(lat * population) / NULLIF(SUM(population), 0), 4) AS lat,
ROUND(SUM(lon * population) / NULLIF(SUM(population), 0), 4) AS lon,
CURRENT_DATE AS refreshed_date CURRENT_DATE AS refreshed_date
FROM serving.pseo_city_costs_de FROM serving.pseo_city_costs_de
GROUP BY country_code, country_name_en, country_slug GROUP BY country_code, country_name_en, country_slug

View File

@@ -8,6 +8,7 @@ daily when the pipeline runs).
from quart import Blueprint, abort, jsonify from quart import Blueprint, abort, jsonify
from .analytics import fetch_analytics from .analytics import fetch_analytics
from .auth.routes import login_required
from .core import fetch_all, is_flag_enabled from .core import fetch_all, is_flag_enabled
bp = Blueprint("api", __name__) bp = Blueprint("api", __name__)
@@ -26,6 +27,7 @@ async def _require_maps_flag() -> None:
@bp.route("/markets/countries.json") @bp.route("/markets/countries.json")
@login_required
async def countries(): async def countries():
"""Country-level aggregates for the markets hub map.""" """Country-level aggregates for the markets hub map."""
await _require_maps_flag() await _require_maps_flag()
@@ -96,23 +98,3 @@ async def city_venues(country_slug: str, city_slug: str):
) )
return jsonify(rows), 200, _CACHE_HEADERS return jsonify(rows), 200, _CACHE_HEADERS
@bp.route("/opportunity/<country_slug>.json")
async def opportunity(country_slug: str):
"""Location-level opportunity scores for the opportunity map."""
await _require_maps_flag()
assert country_slug, "country_slug required"
rows = await fetch_analytics(
"""
SELECT location_name, location_slug, lat, lon,
opportunity_score, market_score,
nearest_padel_court_km,
padel_venue_count, population
FROM serving.location_profiles
WHERE country_slug = ? AND opportunity_score > 0
ORDER BY opportunity_score DESC
LIMIT 500
""",
[country_slug],
)
return jsonify(rows), 200, _CACHE_HEADERS

View File

@@ -9,6 +9,7 @@ from jinja2 import Environment, FileSystemLoader
from markupsafe import Markup from markupsafe import Markup
from quart import Blueprint, abort, g, redirect, render_template, request from quart import Blueprint, abort, g, redirect, render_template, request
from ..analytics import fetch_analytics
from ..core import ( from ..core import (
REPO_ROOT, REPO_ROOT,
capture_waitlist_email, capture_waitlist_email,
@@ -203,6 +204,14 @@ async def markets():
) )
articles = await _filter_articles(q, country, region) articles = await _filter_articles(q, country, region)
map_countries = await fetch_analytics("""
SELECT country_code, country_name_en, country_slug,
city_count, total_venues,
avg_market_score, avg_opportunity_score,
lat, lon
FROM serving.pseo_country_overview
ORDER BY total_venues DESC
""")
return await render_template( return await render_template(
"markets.html", "markets.html",
@@ -212,6 +221,7 @@ async def markets():
current_q=q, current_q=q,
current_country=country, current_country=country,
current_region=region, current_region=region,
map_countries=map_countries,
) )

View File

@@ -92,27 +92,25 @@
}); });
} }
fetch('/api/markets/countries.json') var data = {{ map_countries | tojson }};
.then(function(r) { return r.json(); }) if (data.length) {
.then(function(data) { var maxV = Math.max.apply(null, data.map(function(d) { return d.total_venues; }));
if (!data.length) return; var lang = document.documentElement.lang || 'en';
var maxV = Math.max.apply(null, data.map(function(d) { return d.total_venues; })); data.forEach(function(c) {
var lang = document.documentElement.lang || 'en'; if (!c.lat || !c.lon) return;
data.forEach(function(c) { var size = 12 + 44 * Math.sqrt(c.total_venues / maxV);
if (!c.lat || !c.lon) return; var color = scoreColor(c.avg_market_score);
var size = 12 + 44 * Math.sqrt(c.total_venues / maxV); var oppColor = c.avg_opportunity_score >= 60 ? '#16A34A' : (c.avg_opportunity_score >= 30 ? '#D97706' : '#3B82F6');
var color = scoreColor(c.avg_market_score); var tip = '<strong>' + c.country_name_en + '</strong><br>'
var oppColor = c.avg_opportunity_score >= 60 ? '#16A34A' : (c.avg_opportunity_score >= 30 ? '#D97706' : '#3B82F6'); + c.total_venues + ' venues · ' + c.city_count + ' cities<br>'
var tip = '<strong>' + c.country_name_en + '</strong><br>' + '<span style="color:' + color + ';font-weight:600;">Padelnomics Market Score: ' + c.avg_market_score + '/100</span><br>'
+ c.total_venues + ' venues · ' + c.city_count + ' cities<br>' + '<span style="color:' + oppColor + ';font-weight:600;">Padelnomics Opportunity Score: ' + (c.avg_opportunity_score || 0) + '/100</span>';
+ '<span style="color:' + color + ';font-weight:600;">Padelnomics Market Score: ' + c.avg_market_score + '/100</span><br>' L.marker([c.lat, c.lon], { icon: makeIcon(size, color) })
+ '<span style="color:' + oppColor + ';font-weight:600;">Padelnomics Opportunity Score: ' + (c.avg_opportunity_score || 0) + '/100</span>'; .bindTooltip(tip, { className: 'map-tooltip', direction: 'top', offset: [0, -Math.round(size / 2)] })
L.marker([c.lat, c.lon], { icon: makeIcon(size, color) }) .on('click', function() { window.location = '/' + lang + '/markets/' + c.country_slug; })
.bindTooltip(tip, { className: 'map-tooltip', direction: 'top', offset: [0, -Math.round(size / 2)] }) .addTo(map);
.on('click', function() { window.location = '/' + lang + '/markets/' + c.country_slug; })
.addTo(map);
});
}); });
}
})(); })();
</script> </script>
{% endblock %} {% endblock %}

View File

@@ -87,6 +87,46 @@ async def opportunity_map():
return await render_template("opportunity_map.html", countries=countries) return await render_template("opportunity_map.html", countries=countries)
@bp.route("/opportunity-map/data")
async def opportunity_map_data():
"""HTMX partial: opportunity + reference data islands for Leaflet map."""
from ..core import is_flag_enabled
if not await is_flag_enabled("maps", default=True):
abort(404)
country_slug = request.args.get("country", "")
if not country_slug:
return ""
opp_points = await fetch_analytics(
"""
SELECT location_name, location_slug, lat, lon,
opportunity_score, market_score,
nearest_padel_court_km, padel_venue_count, population
FROM serving.location_profiles
WHERE country_slug = ? AND opportunity_score > 0
ORDER BY opportunity_score DESC
LIMIT 500
""",
[country_slug],
)
ref_points = await fetch_analytics(
"""
SELECT city_name, city_slug, lat, lon,
city_padel_venue_count AS padel_venue_count,
market_score, population
FROM serving.location_profiles
WHERE country_slug = ? AND city_slug IS NOT NULL
ORDER BY city_padel_venue_count DESC
LIMIT 200
""",
[country_slug],
)
return await render_template(
"partials/opportunity_map_data.html",
opp_points=opp_points,
ref_points=ref_points,
)
@bp.route("/imprint") @bp.route("/imprint")
async def imprint(): async def imprint():
lang = g.get("lang", "en") lang = g.get("lang", "en")

View File

@@ -24,7 +24,10 @@
<div class="card mb-4" style="padding: 1rem 1.25rem;"> <div class="card mb-4" style="padding: 1rem 1.25rem;">
<label class="form-label" for="opp-country-select" style="margin-bottom: 0.5rem; display:block;">Select a country</label> <label class="form-label" for="opp-country-select" style="margin-bottom: 0.5rem; display:block;">Select a country</label>
<select id="opp-country-select" class="form-input" style="max-width: 280px;"> <select id="opp-country-select" name="country" class="form-input" style="max-width:280px;"
hx-get="{{ url_for('public.opportunity_map_data') }}"
hx-target="#map-data"
hx-trigger="change">
<option value="">— choose country —</option> <option value="">— choose country —</option>
{% for c in countries %} {% for c in countries %}
<option value="{{ c.country_slug }}">{{ c.country_name_en }}</option> <option value="{{ c.country_slug }}">{{ c.country_name_en }}</option>
@@ -33,6 +36,7 @@
</div> </div>
<div id="opportunity-map"></div> <div id="opportunity-map"></div>
<div id="map-data" style="display:none;"></div>
<div class="mt-4 text-sm text-slate"> <div class="mt-4 text-sm text-slate">
<strong>Circle size:</strong> population &nbsp;|&nbsp; <strong>Circle size:</strong> population &nbsp;|&nbsp;
@@ -86,53 +90,48 @@
: (p || ''); : (p || '');
} }
function loadCountry(slug) { function renderMap() {
oppLayer.clearLayers(); oppLayer.clearLayers();
refLayer.clearLayers(); refLayer.clearLayers();
if (!slug) return; var oppEl = document.getElementById('opp-data');
var refEl = document.getElementById('ref-data');
if (!oppEl) return;
var oppData = JSON.parse(oppEl.textContent);
var refData = JSON.parse(refEl.textContent);
fetch('/api/opportunity/' + slug + '.json') refData.forEach(function(c) {
.then(function(r) { return r.json(); }) if (!c.lat || !c.lon || !c.padel_venue_count) return;
.then(function(data) { L.marker([c.lat, c.lon], { icon: REF_ICON })
if (!data.length) return; .bindTooltip(c.city_name + ' — ' + c.padel_venue_count + ' existing venues',
var maxPop = Math.max.apply(null, data.map(function(d) { return d.population || 1; })); { className: 'map-tooltip', direction: 'top', offset: [0, -7] })
var bounds = []; .addTo(refLayer);
data.forEach(function(loc) { });
if (!loc.lat || !loc.lon) return;
var size = 8 + 40 * Math.sqrt((loc.population || 1) / maxPop);
var color = oppColor(loc.opportunity_score);
var dist = loc.nearest_padel_court_km != null
? loc.nearest_padel_court_km.toFixed(1) + ' km to nearest court'
: 'No nearby courts';
var mktColor = loc.market_score >= 60 ? '#16A34A' : (loc.market_score >= 30 ? '#D97706' : '#DC2626');
var tip = '<strong>' + loc.location_name + '</strong><br>'
+ '<span style="color:' + color + ';font-weight:600;">Padelnomics Opportunity Score: ' + loc.opportunity_score + '/100</span><br>'
+ '<span style="color:' + mktColor + ';font-weight:600;">Padelnomics Market Score: ' + (loc.market_score || 0) + '/100</span><br>'
+ dist + ' · Pop. ' + fmtPop(loc.population);
L.marker([loc.lat, loc.lon], { icon: makeIcon(size, color) })
.bindTooltip(tip, { className: 'map-tooltip', direction: 'top', offset: [0, -Math.round(size / 2)] })
.addTo(oppLayer);
bounds.push([loc.lat, loc.lon]);
});
if (bounds.length) map.fitBounds(bounds, { padding: [30, 30] });
});
// Existing venues as small gray reference dots (drawn first = behind opp dots) if (!oppData.length) return;
fetch('/api/markets/' + slug + '/cities.json') var maxPop = Math.max.apply(null, oppData.map(function(d) { return d.population || 1; }));
.then(function(r) { return r.json(); }) var bounds = [];
.then(function(data) { oppData.forEach(function(loc) {
data.forEach(function(c) { if (!loc.lat || !loc.lon) return;
if (!c.lat || !c.lon || !c.padel_venue_count) return; var size = 8 + 40 * Math.sqrt((loc.population || 1) / maxPop);
L.marker([c.lat, c.lon], { icon: REF_ICON }) var color = oppColor(loc.opportunity_score);
.bindTooltip(c.city_name + ' — ' + c.padel_venue_count + ' existing venues', var dist = loc.nearest_padel_court_km != null
{ className: 'map-tooltip', direction: 'top', offset: [0, -7] }) ? loc.nearest_padel_court_km.toFixed(1) + ' km to nearest court'
.addTo(refLayer); : 'No nearby courts';
}); var mktColor = loc.market_score >= 60 ? '#16A34A' : (loc.market_score >= 30 ? '#D97706' : '#DC2626');
}); var tip = '<strong>' + loc.location_name + '</strong><br>'
+ '<span style="color:' + color + ';font-weight:600;">Padelnomics Opportunity Score: ' + loc.opportunity_score + '/100</span><br>'
+ '<span style="color:' + mktColor + ';font-weight:600;">Padelnomics Market Score: ' + (loc.market_score || 0) + '/100</span><br>'
+ dist + ' · Pop. ' + fmtPop(loc.population);
L.marker([loc.lat, loc.lon], { icon: makeIcon(size, color) })
.bindTooltip(tip, { className: 'map-tooltip', direction: 'top', offset: [0, -Math.round(size / 2)] })
.addTo(oppLayer);
bounds.push([loc.lat, loc.lon]);
});
if (bounds.length) map.fitBounds(bounds, { padding: [30, 30] });
} }
document.getElementById('opp-country-select').addEventListener('change', function() { document.body.addEventListener('htmx:afterSwap', function(e) {
loadCountry(this.value); if (e.detail.target.id === 'map-data') renderMap();
}); });
})(); })();
</script> </script>

View File

@@ -0,0 +1,2 @@
<script id="opp-data" type="application/json">{{ opp_points | tojson }}</script>
<script id="ref-data" type="application/json">{{ ref_points | tojson }}</script>